Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden images: admin can hide an image #1383

Closed
0pdd opened this issue May 4, 2020 · 3 comments
Closed

Hidden images: admin can hide an image #1383

0pdd opened this issue May 4, 2020 · 3 comments
Assignees
@php-coder
Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/improvement priority/important techdebt
Milestone
0.4.6

Comments

@0pdd
Copy link

0pdd commented May 4, 2020 •
edited by php-coder
Loading

The puzzle 1356-1188ca31 from #1356 has to be resolved:

mystamps/src/main/webapp/WEB-INF/views/series/info.html

Line 173 in 01dca27

<!--/* @todo #1356 Hidden images: admin can hide an image */-->

The puzzle was created by Slava Semushin on 04-May-20.
@0pdd 0pdd added the techdebt label May 4, 2020
@php-coder php-coder modified the milestones: 0.5, next, 0.4.5 Jun 18, 2020
@php-coder php-coder self-assigned this Aug 15, 2020
@php-coder php-coder modified the milestones: 0.4.5, 0.4.6 Dec 30, 2020
@php-coder
Copy link
Owner

Perhaps, adding a hidden image might be more useful at this point. While we can add an image and hide it later, it has a side-effect where series updated_at time is changing.

@php-coder
Copy link
Owner

We should show a form for hiding images only when a series has more than one image.

Other thoughts: do we need to make an image visible again?

@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Feb 7, 2021
php-coder added a commit that referenced this issue Feb 7, 2021
@php-coder
task: add a prototype for a form for hiding the images
f27faf0 
Part of #1383
php-coder added a commit that referenced this issue Feb 7, 2021
@php-coder
task: implement a basic controller and client-server communication
41d9d4d 
Part of #1383
@php-coder php-coder mentioned this issue Feb 8, 2021
Open
php-coder added a commit that referenced this issue Feb 8, 2021
@php-coder
feat: admin can hide an image
75c5589 
Part of #1383
php-coder added a commit that referenced this issue Feb 10, 2021
@php-coder
chore(all-use-cases.puml): admin can hide an image
5e4dfe3 
Part of #1383

[skip ci]
@php-coder php-coder mentioned this issue Feb 28, 2021
Open
php-coder added a commit that referenced this issue Feb 28, 2021
@php-coder
chore: remove stale @todo comment.
8ac8911 
Part of #1383

[skip ci]
@php-coder
Copy link
Owner

Done.

@0pdd 0pdd mentioned this issue Oct 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/improvement priority/important techdebt
Projects
None yet
Milestone
0.4.6
Development

No branches or pull requests
2 participants
@php-coder @0pdd