Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to add a comment to a series #1505

Closed
php-coder opened this issue Jan 20, 2021 · 4 comments
Closed

As a user I want to add a comment to a series #1505

php-coder opened this issue Jan 20, 2021 · 4 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented impact/changelog This change should be reflected in the NEWS.txt file kind/feature priority/important
Milestone
0.4.6

Comments

@php-coder
Copy link
Owner

This feature was requested by our user.

One point to think about: should a user add a comment to a whole series or rather to its instance in the collection?
@php-coder php-coder added this to the 0.4.6 milestone Jan 20, 2021
@php-coder php-coder self-assigned this Jan 20, 2021
@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Jan 20, 2021
@php-coder
Copy link
Owner Author

One point to think about: should a user add a comment to a whole series or rather to its instance in the collection?

Because admin already has such ability and it works for a series rather than an instance, let's implement it similarly for users. Easy migration at least. Comments to the instances can be added later anyway.

@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Jan 21, 2021
@php-coder
Copy link
Owner Author

Should we also remove possibility to add a comment during a series creation?

@php-coder
Copy link
Owner Author

Should we also remove possibility to add a comment during a series creation?

Yes, we should.

@php-coder php-coder reopened this Jan 24, 2021
@php-coder
Copy link
Owner Author

Because admin already has such ability and it works for a series rather than an instance

Also, such comments are visible to all admins, while the new implementation will bind all existing comments to a single admin user.

php-coder added a commit that referenced this issue Jan 31, 2021
@php-coder
chore: fix a unit test for the case when userId is null
75fd26c 
Correction for 899ff5e commit.

Relate to #1505
php-coder added a commit that referenced this issue Jan 31, 2021
@php-coder
chore: mark series_comments.comment field as NOT NULL
00f0a4d 
Should be in 899ff5e commit.

Part of #1505
This was referenced Jan 31, 2021
Closed
Open
@0pdd 0pdd mentioned this issue Oct 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented impact/changelog This change should be reflected in the NEWS.txt file kind/feature priority/important
Projects
None yet
Milestone
0.4.6
Development

No branches or pull requests
1 participant
@php-coder