Skip to content

JdbcCountryDaoTest and JdbcCategoryDaoTest should use the same Spring Context #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jul 10, 2022 · 2 comments
Closed

JdbcCountryDaoTest and JdbcCategoryDaoTest should use the same Spring Context #1589

php-coder opened this issue Jul 10, 2022 · 2 comments
Assignees
@php-coder
Labels
ADR/needed A decision has been made and it needs to be documented area/optimization This change could speed up our site area/unit tests complexity/hard dependency/spring Task is related to Spring Framework
Milestone
0.4.7

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 10, 2022 •
edited
Loading

Related: https://rieckpil.de/improve-build-times-with-context-caching-from-spring-test/
@php-coder php-coder added this to the next milestone Jul 10, 2022
@php-coder php-coder added the area/optimization This change could speed up our site label Jul 10, 2022
php-coder added a commit that referenced this issue Jul 10, 2022
@php-coder
chore: add commented out configuration for troubleshooting issues wit…
2dc3eed 
…h caching of Spring contexts

Relate to #1589

[skip ci]
@php-coder
Copy link
Owner Author

It seems like the issue was fixed in c7dc4b1 (as part of #1151) when we removed different locations parameters.

@php-coder
Copy link
Owner Author

I also created antoinemeyer/spring-test-context-cache-limiter#4 because usage of this tools makes me think that the problem is still here while the problem was the tool itself :-/

@php-coder php-coder self-assigned this Jul 10, 2022
@php-coder php-coder modified the milestones: next, 0.4.7 Jul 10, 2022
@php-coder php-coder added the ADR/needed A decision has been made and it needs to be documented label Jul 10, 2022
php-coder added a commit that referenced this issue Jul 15, 2022
@php-coder
chore: use spring-test-context-cache-limiter to control a number of t…
3862eeb 
…est context

This should prevent the cases when tests use different contexts like we had in #1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
ADR/needed A decision has been made and it needs to be documented area/optimization This change could speed up our site area/unit tests complexity/hard dependency/spring Task is related to Spring Framework
Projects
None yet
Milestone
0.4.7
Development

No branches or pull requests
1 participant
@php-coder