Skip to content

Move Currency class to dao.dto package #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Aug 24, 2016 · 1 comment
Closed

Move Currency class to dao.dto package #458

php-coder opened this issue Aug 24, 2016 · 1 comment
Assignees
@cssru
Labels
refactoring techdebt
Milestone
0.4

Comments

@php-coder
Copy link
Owner

Classes from ru.mystamps.web.dao.dto package shouldn't use classes from ru.mystamps.web.service.dto because dao shouldn't depend on service. Since c5e733b commit we have PurchaseAndSaleDto that uses Currency class. We should move Currency to ru.mystamps.web.dao.dto package.

Tech debt for: c5e733b (#198)
@php-coder php-coder added this to the next milestone Aug 24, 2016
@php-coder
Copy link
Owner Author

php-coder commented Aug 24, 2016 •
edited
Loading

This is a really trivial operation and could be done in one hot key in the IntelliJ IDEA: https://www.jetbrains.com/help/idea/2016.2/move-class-dialog.html

@php-coder php-coder modified the milestones: 0.4, next Aug 24, 2016
@php-coder php-coder removed the ready label Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cssru cssru

Labels
refactoring techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @cssru