Skip to content

Admin can add a link to a page where someone sells this series #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Jul 28, 2015 · 7 comments
Closed

Admin can add a link to a page where someone sells this series #198

php-coder opened this issue Jul 28, 2015 · 7 comments
Assignees
Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Milestone

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 28, 2015

When admin opens page with series info, he should see the form with the header "Add info about selling" and the following fields/labels:

  • Date: optional text field, accept value in format 12.10.2012, date must be in past
  • Seller: required <select> field, the values are populated from the transaction_participants table
  • Url: optional text field. We can try to use <input type="url">. Let's try to use special validation annotation from the hibernate-validator
  • Price: price and currency: required fields.
  • Alternative price/currency: optional fields.
  • Buyer: optional <select> field.

Additional validation:

  • buyer and seller should be different
  • price and alternative price should be different

Things to not forget:

  • Protect by togglz and spring security
  • Protect URL for form submission by Spring Security
@php-coder php-coder self-assigned this Jul 28, 2015
@php-coder php-coder added this to the 0.4 milestone Jul 28, 2015
@php-coder php-coder modified the milestones: 0.5, 0.4 Jan 2, 2016
@php-coder php-coder removed the ready label Jan 2, 2016
@php-coder php-coder assigned cssru and unassigned php-coder Apr 26, 2016
@php-coder php-coder added the impact/changelog This change should be reflected in the NEWS.txt file label Apr 26, 2016
@php-coder php-coder modified the milestones: next, 0.5 Jul 29, 2016
@php-coder php-coder changed the title Admin could add a link to a page where someone sells this series Admin can add a link to a page where someone sells this series Aug 23, 2016
@php-coder
Copy link
Owner Author

@cssru I've updated description with my current vision.

@cssru
Copy link
Contributor

cssru commented Aug 29, 2016

Ok. But I can't see the way to add buyers and sellers to transactions_participants table. Console?

@php-coder
Copy link
Owner Author

We we'll implement it later.

@cssru
Copy link
Contributor

cssru commented Aug 29, 2016

Additional validation: buyer and price should be different.

Explain, please. I thought "John Smith" and "100 USD" anyway are different.

@php-coder
Copy link
Owner Author

Good catch! See updated. It was a typo, I mean "buyer and seller".

@cssru
Copy link
Contributor

cssru commented Aug 29, 2016

buyer and seller should be different

Wanna check it on backend level only or on front-end level too?

@php-coder
Copy link
Owner Author

We need to create (re-use?) JSR303 validator, so, yes, backend only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/changelog This change should be reflected in the NEWS.txt file kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants