Skip to content

/series/{id}: show the prices in the same way everywhere #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
php-coder opened this issue Aug 28, 2016 · 12 comments
Open

/series/{id}: show the prices in the same way everywhere #473

php-coder opened this issue Aug 28, 2016 · 12 comments
Milestone

Comments

@php-coder
Copy link
Owner

php-coder commented Aug 28, 2016

At present the prices from catalogs and in sellers/buyers block use different ways of displaying and hence they look different (1 vs 1.00 and 1.1 vs 1.10):
2016-08-28 14 12 52
We should decide on what way of formatting we're using and use it everywhere.

Related to #198

@php-coder
Copy link
Owner Author

@cssru WDYT?

I like my approach because it looks more clean and less verbose. In the same time I like your solution because it uses standard utils from Thymeleaf.

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

I suggest to use two digits after point.
1.5 EUR looks weird for me :)

@php-coder
Copy link
Owner Author

1.5 EUR looks weird for me :)

Hmm.... Why? It's obvious for me :)

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

'cause there is not one euro and a half. 'cause there is one euro and 50 cent.

@php-coder
Copy link
Owner Author

Ok, I agree with that.

But I don't like to see 80.00 RUB instead of 80 RUB. WDYT about this case then?

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

Ok. 80.56 and 80.00 looks in one style, but 80.56 and 80 - in different and then uncool :)

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

I suggest to ask for some accountant :)

@php-coder
Copy link
Owner Author

php-coder commented Aug 28, 2016

I've just asked my wife (she is an accountant) that's why I agreed on 80.50 :) But here is a different area -- we're more close to a shop than to a bank. We don't need to be so strict here and it's better to be human-oriented. For example, I believe that the prices in the shops will look like 80 (instead of 80.00) and 80.5 (instead of 80.50). But maybe I'm wrong here.

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

Is I remember prices look like 80.00 written on special tickets. Maybe, in your country they look different?

@cssru
Copy link
Contributor

cssru commented Aug 28, 2016

To be closer to reality we should write "two ground bucks" :)

@php-coder
Copy link
Owner Author

Commit 9287473 (#884) added yet another place where prices are shown: /collection/{slug}/estimation.

@php-coder
Copy link
Owner Author

After rewriting to JavaScript/React we might use browser's internationalization: https://blog.bitsrc.io/new-intl-apis-in-javascript-c50dc89d2cf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants