Skip to content

Automate code review process with Danger (maximum requirements) #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 of 26 tasks
Tracked by #1600
php-coder opened this issue Feb 21, 2017 · 1 comment
Closed
10 of 26 tasks
Tracked by #1600

Automate code review process with Danger (maximum requirements) #537

php-coder opened this issue Feb 21, 2017 · 1 comment

Comments

@php-coder
Copy link
Owner

php-coder commented Feb 21, 2017

  • warn when author's name doesn't contains surname (for example, MrRobot <[email protected]>)
  • warn about branches in my repository (xxx wants to merge 1 commit into master from gh510deny_add_and_list_as_country_names)
  • html5validator: why build not fails?
  • html5validator: handle multilines (1.16-5.73) (see https://travis-ci.org/php-coder/mystamps/jobs/222367539)
  • warn: PR has multiple commits
  • show info message when all tests have passed
  • PR from master branch (source branch should starts from ghXXX_)
  • detect "Merge remote-tracking branch 'refs/remotes/php-coder/master'"
  • after modifying css/js files, Url.RESOURCES_VERSION should be bumped
  • warn about pull request to non-master branch (?)
  • error about space-only hunks
@@ -1031,7 +1031,7 @@
                <system>GitHub</system>
                <url>https://github.com/php-coder/mystamps/issues</url>
        </issueManagement>
-
+
        <ciManagement>
                <system>Travis CI</system>
                <url>https://travis-ci.org/php-coder/mystamps</url>
  • error about maven dependencies with explicit version (not a property)
<dependency>
    <groupId>javax.validation</groupId>
    <artifactId>validation-api</artifactId>
    <version>1.1.0.Final</version>
</dependency>
  • codenarc: detect checks that always should be ignored
  • cs/pmd/codenarc/findbugs: suggest a way of ignoring error (or documentation on wiki is enough?)
  • robotframework: try to findout the test case and use it for highlighting line numbers
  • surefire plugin: try to findout the test case and use it for highlighting line numbers
  • failsafe plugin: try to findout the test case and use it for highlighting line numbers
  • pass file/line to fail()
  • warn: code was modified but there are no modifications in tests
  • warn: commit message should not have Fixes # comment (see also https://help.github.com/articles/closing-issues-via-commit-messages/)
  • warn: PR description should have Addressed to # comment
  • add documentation
  • filter Build info/System info/Driver info from robotframework message
  • more strict check forUrl.RESOURCES_VERSION (check that user modified not just a Url file but the exact this constant)
  • sortpom-maven-plugin, remove pwd: The file /home/travis/build/php-coder/mystamps/pom.xml is not sorted
  • make it link: You can read how to do it here: https://davidwalsh.name/squash-commits-git

Follow-up to #536
Pull request to see this in action: #533

@php-coder php-coder added this to the next milestone Feb 21, 2017
@php-coder php-coder self-assigned this Feb 21, 2017
php-coder added a commit that referenced this issue Mar 15, 2017
php-coder added a commit that referenced this issue Mar 15, 2017
php-coder added a commit that referenced this issue Mar 15, 2017
php-coder added a commit that referenced this issue Mar 22, 2017
Should be in 9dfd381 commit.

Addressed to #537

No functional changes.

[ci skip]
php-coder added a commit that referenced this issue May 18, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
Should be in 9dfd381 commit.

Addressed to php-coder#537

No functional changes.

[ci skip]
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@php-coder php-coder modified the milestones: next, 0.4.7 Dec 4, 2022
@php-coder
Copy link
Owner Author

I have decided discontinue usage of Danger (see #1600).

@php-coder php-coder closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant