Skip to content

Series import: add integration test for the case when parsed value doesn't match database #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
0pdd opened this issue Dec 6, 2017 · 0 comments
Open

Series import: add integration test for the case when parsed value doesn't match database #748

0pdd opened this issue Dec 6, 2017 · 0 comments
Labels
area/integration tests techdebt

Comments

@0pdd
Copy link

0pdd commented Dec 6, 2017 •
edited by php-coder
Loading

The puzzle 684-b075a77e (from #684) in src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java has to be resolved: "Series import: add integration test for the case when parsed value don't match database"

mystamps/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java

Lines 182 to 183 in 6091f30

// @todo #684 Series import: add integration test
// for the case when parsed value don't match database

The puzzle was created by Slava Semushin on 04-Dec-17
0pdd referenced this issue Dec 6, 2017
@php-coder
SeriesInfoExtractorServiceImplTest: add more unit tests.
6091f30 
Addressed to #686

No functional changes.
@php-coder php-coder changed the title Series import: add integration test for the case when... Series import: add integration test for the case when parsed value don't match database Dec 6, 2017
This was referenced Dec 6, 2017
Closed
Open
Repository owner deleted a comment from 0pdd Dec 7, 2017
@php-coder php-coder changed the title Series import: add integration test for the case when parsed value don't match database Series import: add integration test for the case when parsed value doesn't match database Dec 8, 2017
php-coder added a commit that referenced this issue Jun 16, 2023
@php-coder
style: modify TODO comment to match with a title of the existing issue
947f7b2 
Relate to #1610
Relate to #748
php-coder added a commit that referenced this issue Jun 22, 2023
@php-coder
ci: manually update puzzle id after changing a comment
6cc36cc 
The comment has been modified in 947f7b2 commit

The error was:
ERROR: 684-0b0d5497 => #748: issue looks identical but its body doesn't contain the puzzle id (684-0b0d5497)!
ERROR: Perhaps, the puzzle id got changed after issue creation
ERROR: Body: The puzzle 684-b075a77e (from #684) in [src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java](https://github.com/php-coder/mystamps/blob/6091f30a29dc445f8f544cc05e359df910c67eb5/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java#L182-L183) has to be resolved: "Series import: add integration test for the case when parsed value don't match database"  https://github.com/php-coder/mystamps/blob/6091f30a29dc445f8f544cc05e359df910c67eb5/src/main/java/ru/mystamps/web/service/SeriesImportServiceImpl.java#L182-L183  The puzzle was created by Slava Semushin on 04-Dec-17
ERROR: Ways to resolve:
ERROR:     1) edit #748 and modify its body to contain 684-0b0d5497
ERROR:     2) manually create a mapping between this puzzle and the issue:
ERROR:        echo '684-0b0d5497\t748\topen\tmanually' >>generated-todos/todos-on-github.tsv

Part of #1610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integration tests techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @0pdd