Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/series/{id}(currency): must be required when price is specified #886

Closed
0pdd opened this issue Jun 16, 2018 · 4 comments
Closed

/series/{id}(currency): must be required when price is specified #886

0pdd opened this issue Jun 16, 2018 · 4 comments
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented Jun 16, 2018

The puzzle 663-4e951c08 from #663 has to be resolved:

// @todo #663 /series/{id}(currency): must be required when price is specified

The puzzle was created by Slava Semushin on 15-Jun-18.

@php-coder
Copy link
Owner

Seems like we can use @NotNullIfFirstField here.

@KrivenkoAlexander
Copy link
Contributor

KrivenkoAlexander commented Feb 27, 2019 via email

@php-coder
Copy link
Owner

@KrivenkoAlexander This issue isn't assigned to you actually. Would you like to work on it? Assign to yourself then :)

@php-coder
Copy link
Owner

Update: in #678 I introduced @BothOrNoneRequired validator that should be used in this case -- it also protect from submitting currency only.

@php-coder php-coder modified the milestones: next, 0.4.2 Sep 9, 2019
@php-coder php-coder modified the milestones: 0.4.2, next Nov 6, 2019
@php-coder php-coder self-assigned this Feb 21, 2020
@php-coder php-coder modified the milestones: next, 0.4.3 Feb 21, 2020
@php-coder php-coder modified the milestones: 0.4.3, 0.4.4 Mar 17, 2020
@php-coder php-coder modified the milestones: 0.4.4, next May 23, 2020
@php-coder php-coder modified the milestones: next, 0.4.6 Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants