Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php-enqueue/enqueue-dev
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.8.15
Choose a base ref
...
head repository: php-enqueue/enqueue-dev
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.8.16
Choose a head ref
  • 9 commits
  • 4 files changed
  • 3 contributors

Commits on Jan 8, 2018

  1. [Sqs] Allow array-based DSN configuration

    I encountered a problem with using DSN-based configuration in Symfony 4, where the 'dsn' value was always being passed as an array key. The constructor did not properly handle this, and the primary symptom of this was a constant complaint that the 'region' was not set, even though it was present in the DSN.
    beryllium authored Jan 8, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f99b971 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8c95f5e View commit details
  3. Whitespace cleanup

    beryllium authored Jan 8, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    115653f View commit details

Commits on Jan 12, 2018

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8106cef View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    38c2046 View commit details
  3. Copy the full SHA
    dfd4499 View commit details
  4. Copy the full SHA
    c7a0940 View commit details

Commits on Jan 13, 2018

  1. Merge pull request #315 from beryllium/patch-1

    [Sqs] Allow array-based DSN configuration
    makasim authored Jan 13, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    826b41b View commit details
  2. Release 0.8.16

    makasim committed Jan 13, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    makasim Max Kotliar
    Copy the full SHA
    44fb0d8 View commit details
Showing with 25 additions and 1 deletion.
  1. +5 −0 CHANGELOG.md
  2. +1 −1 pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php
  3. +6 −0 pkg/sqs/SqsConnectionFactory.php
  4. +13 −0 pkg/sqs/Tests/SqsConnectionFactoryConfigTest.php
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## [0.8.16](https://github.com/php-enqueue/enqueue-dev/tree/0.8.16) (2018-01-13)
[Full Changelog](https://github.com/php-enqueue/enqueue-dev/compare/0.8.15...0.8.16)

- \[Sqs\] Allow array-based DSN configuration [\#315](https://github.com/php-enqueue/enqueue-dev/pull/315) ([beryllium](https://github.com/beryllium))

## [0.8.15](https://github.com/php-enqueue/enqueue-dev/tree/0.8.15) (2018-01-12)
[Full Changelog](https://github.com/php-enqueue/enqueue-dev/compare/0.8.14...0.8.15)

2 changes: 1 addition & 1 deletion pkg/enqueue-bundle/Tests/Functional/UseCasesTest.php
Original file line number Diff line number Diff line change
@@ -193,7 +193,7 @@ public function provideEnqueueConfigs()
]];

// travis build does not have secret env vars if contribution is from outside.
if (false == getenv('AWS_SQS_KEY')) {
if (getenv('AWS_SQS_KEY')) {
yield 'sqs' => [[
'transport' => [
'default' => 'sqs',
6 changes: 6 additions & 0 deletions pkg/sqs/SqsConnectionFactory.php
Original file line number Diff line number Diff line change
@@ -42,6 +42,12 @@ public function __construct($config = 'sqs:')
} elseif (is_string($config)) {
$config = $this->parseDsn($config);
} elseif (is_array($config)) {
$dsn = array_key_exists('dsn', $config) ? $config['dsn'] : null;
unset($config['dsn']);

if ($dsn) {
$config = array_replace($config, $this->parseDsn($dsn));
}
} else {
throw new \LogicException('The config must be either an array of options, a DSN string or null');
}
13 changes: 13 additions & 0 deletions pkg/sqs/Tests/SqsConnectionFactoryConfigTest.php
Original file line number Diff line number Diff line change
@@ -104,6 +104,19 @@ public static function provideConfigs()
],
];

yield [
['dsn' => 'sqs:?key=theKey&secret=theSecret&token=theToken&lazy=0'],
[
'key' => 'theKey',
'secret' => 'theSecret',
'token' => 'theToken',
'region' => null,
'retries' => 3,
'version' => '2012-11-05',
'lazy' => false,
],
];

yield [
['key' => 'theKey', 'secret' => 'theSecret', 'token' => 'theToken', 'lazy' => false],
[