[Sqs] Allow array-based DSN configuration #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered a problem with using DSN-based configuration in Symfony 4, where the 'dsn' value was always being passed as an array key. The constructor did not properly handle this, and the primary symptom of this was a constant complaint that the 'region' was not set, even though it was present in the DSN.
makasim
reviewed
Jan 9, 2018
pkg/sqs/SqsConnectionFactory.php
Outdated
| throw new \LogicException('The config must be either an array of options, a DSN string, or null'); | ||
| } | ||
|
|
||
| if (count($config) == 1 && array_key_exists('dsn', $config)) { |
There was a problem hiding this comment.
dsn option could be used with other options in config. It should work like here
The config is treat as default options, and options from dsn could overwrite them
|
Looks like the tests are failing due to a misconfiguration with IAM credentials? Unless I'm mistaken, it doesn't seem to be related to the PR. |
|
It is a security policy, Travis does not add secret envs vars if PR author is not member of org. I'll check it myself and merge. |
|
that should fix it dfd4499 |
|
Merged the latest master, hopefully everything will pass now :) |
|
Thank you |
ASKozienko
pushed a commit
that referenced
this pull request
Nov 2, 2018
[Sqs] Allow array-based DSN configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a problem with using DSN-based configuration in Symfony 4, where the 'dsn' value was always being passed as an array key. The constructor did not properly handle this, and the primary symptom of this was a constant complaint that the 'region' was not set, even though it was present in the DSN.