Skip to content

Split tests into different matrices; fix highest/lowest dependencies #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Feb 20, 2021

Conversation

andrewmy
Copy link
Contributor

@andrewmy andrewmy commented Feb 11, 2021

The original build matrix looked quite funky, trying to make it more understandable and expandable here.

Also recently I encountered bugs in a different library which had quite wide lowest/highest deps gap, made me think we should test it here as well.

  • Split tests into different matrices;
  • Add highest/lowest dependencies;
  • Fix lowest dependency versions;
  • Drop Symfony 4.3 and 5.0 tests;
  • Fix composer install race condition in CI.

@andrewmy andrewmy changed the title Split tests into different matrices Split tests into different matrices; fix highest/lowest dependencies Feb 11, 2021
@andrewmy
Copy link
Contributor Author

Turns out bunny 0.2 had open php req and "allowed" php 8 🙈 Discovered it while bumping react libs to ^1.0.
Had to fix the bunny requirement here which duplicates #1143 — happy to have it merged first if it happens so.

@andrewmy
Copy link
Contributor Author

The matrix is huge :o
Symfony 4.3 and 5.0 are EOL — do we want to test against them? See https://symfony.com/releases

@andrewmy
Copy link
Contributor Author

andrewmy commented Feb 18, 2021

@makasim @Steveb-p now the PR is ready to go, sorry for not making it a draft initially.
I've still got a question about EOL Symfony versions though, see above.

@makasim
Copy link
Member

makasim commented Feb 18, 2021

Symfony 4.3 and 5.0 are EOL — do we want to test against them? See https://symfony.com/releases

I dont think so.

@andrewmy
Copy link
Contributor Author

Looks ready to me now, and also fixes the composer install race condition which may impact other PRs

@makasim makasim merged commit ad8b334 into php-enqueue:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants