Skip to content

Update doctrine/persistence #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2023

Conversation

jlabedo
Copy link
Contributor

@jlabedo jlabedo commented Mar 5, 2023

Update doctrine/persistence to ^3.0

@makasim
Copy link
Member

makasim commented Mar 18, 2023

I think it is too much to support three major versions at the same time.

Could you drop 1.x version ? It was updated about two years ago last time.

@xNarkon
Copy link
Contributor

xNarkon commented May 4, 2023

Any update on this? I can handle this topic if the original owner is out

@makasim
Copy link
Member

makasim commented May 4, 2023

I can handle this topic if the original owner is out

@xNarkon that would be great

@xNarkon
Copy link
Contributor

xNarkon commented May 4, 2023

@makasim #1300

@dgafka
Copy link
Contributor

dgafka commented May 5, 2023

Hey :)

@jlabedo can we drop the version 1 and push it forward?

@jlabedo jlabedo force-pushed the deps-doctrine-persistence branch from 182caa1 to e59ba58 Compare May 11, 2023 20:16
@jlabedo
Copy link
Contributor Author

jlabedo commented May 11, 2023

Sorry for the delay @makasim, the branch is updated. I was super busy at work on a new project that uses enqueue and ecotone framework :)

@jlabedo
Copy link
Contributor Author

jlabedo commented May 12, 2023

@makasim , I think this PR could still be needed even after merging #1300 :

  1. It allows doctrine/persistence 3.0 and not only 3.1
  2. It make ci test against the latest ^3.0: as it is not updated in enqueue-dev root composer.json, the ci is still going on ^2.0 😄 (see: https://github.com/php-enqueue/enqueue-dev/actions/runs/4884813943/jobs/8857137748?pr=1300#step:7:39)

@makasim makasim merged commit ad7491d into php-enqueue:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants