-
Notifications
You must be signed in to change notification settings - Fork 440
PHP_URL_SCHEME doesn't support underscores #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP_URL_SCHEME doesn't support underscores #453
Conversation
…sn't support this
Is it ok if I replace it with a regex check? |
what exactly? |
@coudenysj ping |
The following line (parse_url) doesn't support underscores:
So only a subset of this list is actually supported: enqueue-dev/pkg/dbal/DbalConnectionFactory.php Lines 106 to 121 in 9cea391
|
I don't mind changing it. A PR is very welcome. |
…port underscores)
Here you go. |
Could you re-run the checks? I didn't change anything to the MongoDB testCouldBeConstructedWithCustomConfiguration. |
@coudenysj Mongodb failed test is not related to your changes. I am aware of it. |
PHP_URL_SCHEME doesn't support underscores
php-enqueue/dbal#2