Skip to content

Remove bool typehint for php < 7 supports #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018
+10 −2
Merged

Remove bool typehint for php < 7 supports #513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5027120
Remove bool typehint for php < 7 supports
ArnaudTarroux Aug 22, 2018
89d2330
Missing parenthesis
ArnaudTarroux Aug 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkg/enqueue/Consumption/QueueConsumer.php
View file
Original file line number Diff line number Diff line change
@@ -346,10 +346,18 @@ public function consume(ExtensionInterface $runtimeExtension = null)

/**
* @param bool $enableSubscriptionConsumer
* @throws \Enqueue\Consumption\Exception\InvalidArgumentException
*/
public function enableSubscriptionConsumer(bool $enableSubscriptionConsumer)
public function enableSubscriptionConsumer($enableSubscriptionConsumer)
{
$this->enableSubscriptionConsumer = $enableSubscriptionConsumer;
if (!is_bool($enableSubscriptionConsumer)) {
throw new InvalidArgumentException(
sprintf(
'The argument must be a boolean but got %s.',
is_object($enableSubscriptionConsumer) ? get_class($enableSubscriptionConsumer) : gettype($enableSubscriptionConsumer)
)
);
}
}

/**