Skip to content

Better Symfony doc nav #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2019
Merged

Better Symfony doc nav #862

merged 3 commits into from
May 28, 2019

Conversation

sylfabre
Copy link
Contributor

Actually there is a lot of documentation for Symfony but it's not easy to navigate through the pages as the links always get you back to the general doc instead of a Symfony homepage

Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :)

@makasim
Copy link
Member

makasim commented May 27, 2019

Do the changes still make sense after gh-pages introduction: https://php-enqueue.github.io/ ?

@Steveb-p
Copy link
Contributor

Do the changes still make sense after gh-pages introduction: https://php-enqueue.github.io/ ?

@makasim Kinda still yes. Internal bundle docs should still only go one level up instead of going to top level index.md.

Introducing index.md however is no longer necessary, since it already auto-generates table of contents now. I believe it's also why conflict is reported.

@makasim
Copy link
Member

makasim commented May 28, 2019

@sylfabre could you please resolve conflicts?

@Steveb-p
Copy link
Contributor

@makasim Aren't they already resolved now? I used the magic "resolve conflicts" on github and went through looking what should go where... :)

@makasim makasim merged commit b58edbe into php-enqueue:master May 28, 2019
@makasim
Copy link
Member

makasim commented May 28, 2019

Aren't they already resolved now? I used the magic "resolve conflicts" on github and went through looking what should go where... :)

I always forget about that feature (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants