Remove unused stream factory #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Jul 13, 2017
This ensures we don't add another parameter which might be a BC break compared to v0.1.0 then.
kelunik
force-pushed
the
remove-stream-factory
branch
from
4bc010e to
b860278
Compare
|
There is no need to deprecate it. Just remove it and we release 0.2.0. But the change log should state that we removed it. |
joelwurtz
reviewed
Jul 13, 2017
| /** | ||
| * @param Artax\Client $client HTTP client implementation. | ||
| * @param ResponseFactory $responseFactory Response factory to use or `null` to attempt auto-discovery. | ||
| * @param StreamFactory $streamFactory This parameter will be ignored and removed in the next major version. |
There was a problem hiding this comment.
I think you can remove it directly withtout waiting for a next major and tag the next release a 0.2.0, it will be compliant with semver and as it's a fresh library it should be fine.
There was a problem hiding this comment.
Yes, but that way we can tag v0.1.1 and nobody even has to update their composer.json.
|
We can do that as well, don't really care. |
|
@Nyholm I'd just tag v0.1.1 for now, but if you really want to tag v0.2.0, I can change the PR, too. |
|
Thank you for this PR. |
|
Feel free to tag 0.1.1. |
|
Tagged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove the unused stream factory.
Why?
Because it's unused.