Skip to content

add phpstan to ci build #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 3, 2021
Merged

add phpstan to ci build #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
99bba50
add phpstan to ci build
dbu Oct 25, 2021
7079a08
fixes for phpstan level 1
dbu Oct 25, 2021
66aa9f2
phpstan level 2
dbu Oct 25, 2021
297fda5
fix phpstan level 2
dbu Oct 25, 2021
664c7fd
phpstan level 3
dbu Oct 25, 2021
aa82a78
fix phpstan level 3
dbu Oct 25, 2021
757753a
phpstan level 4
dbu Oct 25, 2021
220a4b5
prefer array_key_exists over isset for more robust code
dbu Oct 25, 2021
95a502b
phpstan level 7
dbu Oct 25, 2021
cb8755b
cleanup type hints and phpdoc
dbu Oct 25, 2021
a519bf9
phpstan level 8
dbu Oct 25, 2021
3f0266a
be more defensive about the value of the cache hit
dbu Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[*.yml]
indent_size = 2
21 changes: 21 additions & 0 deletions .github/workflows/static.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Static analysis

on:
push:
branches:
- master
pull_request:

jobs:
phpstan:
name: PHPStan
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: PHPStan
uses: docker://oskarstark/phpstan-ga
with:
args: analyze --no-progress
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: tests

on:
push:
branches:
- master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents us from running every build twice

pull_request:

jobs:
Expand Down
4 changes: 4 additions & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
parameters:
level: 1
paths:
- src