Skip to content

Allow Symfony 4 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Allow Symfony 4 #88

merged 1 commit into from
Nov 18, 2017

Conversation

OndraM
Copy link
Contributor

@OndraM OndraM commented Nov 10, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Allow Symfony/OptionsResolver 4.x installation.

Why?

Symfony 4 is about to be released this month (and is already in beta). There are no BC breaks in the OptionsResolver component: symfony/options-resolver@3.4...master , so I think we can safely allow its installation.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess with the options resolver we are safe - general symfony 4 would need to be tested more. lets merge, the styleci error is not related.

@makasim
Copy link

makasim commented Nov 16, 2017

any ETA? It blocks me from upgrading enqueue/stomp lib and others.

@Nyholm
Copy link
Member

Nyholm commented Nov 16, 2017

This is awesome. I will make sure this is merged during the Symfony con hack day. I will also fix all other php-http packages.

@Nyholm
Copy link
Member

Nyholm commented Nov 18, 2017

Thank you.

@Nyholm Nyholm merged commit 2df55de into php-http:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants