Skip to content

Remove set methods and lock phpunit #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2018
Merged

Remove set methods and lock phpunit #50

merged 1 commit into from
Dec 25, 2018

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Dec 23, 2018

  1. I have remove setMethods of PHPUnit... since it does not add any extra value having them.
  2. Fixed the expectExceptionMessage.
  3. Locked to PHPUnit 7.5.The library has some deprecations. Locking this will avoid having someone using them... And also it has more features.. so in this way we are allowed to use them...

dbu
dbu approved these changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, love the cleanup!

@dbu dbu merged commit 8ac288b into php-http:master Dec 25, 2018
@gmponos gmponos deleted the improve_unit_tests branch December 25, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmponos @dbu