Skip to content

Support Symfony 5 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Support Symfony 5 #62

merged 1 commit into from
Nov 18, 2019

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@dbu dbu merged commit ff8c0e7 into php-http:master Nov 18, 2019
@crynobone
Copy link

This now cause a regression bug when tested with Symfony 5.

- Installing symfony/options-resolver (dev-master 4c6fc48): Downloading (100%)
1) Katsana\Insurance\Tests\Passport\ClientCredentialsGrantTest::it_cant_attempt_to_authenticate_without_client_id_and_secret
Failed asserting that exception of type "TypeError" matches expected exception "InvalidArgumentException". Message was: "Argument 1 passed to Symfony\Component\OptionsResolver\OptionsResolver::setAllowedValues() must be of the type string, integer given, called in /home/travis/build/katsana/insurance-sdk-php/vendor/php-http/curl-client/src/Client.php on line 98" at

@dbu
Copy link
Contributor

dbu commented Nov 18, 2019

hmm... the curl constants indeed seem to be integer, and OptionsResolver is now declaring the type of the name as string. can you do a PR to cast those curl constants to string? and check whether passing curl options with integer keys still works in the resolver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants