-
Notifications
You must be signed in to change notification settings - Fork 46
Add support for nyholm/psr7 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this PR wanted? I'm using my fork for now but it would be awesome if this PR could be merged and deployed soon! 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is great. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have a tiny worry here: should the new factories not be added at the bottom of the list? being first, if guzzle and nyholm are installed, the autodiscovery might switch what is found. if people really restricted themselves to PSR7, that will not matter, but maybe they relied somehow on guzzle being detected... is there a specific reason to put it on top? otherwise i'd prefer it at the bottom of the list.
It was mentionned in the related issue. Nyholm is the lightest and the more complete PSR implementation. IMO it has its place as the recommended implementation to use by default |
Changing the order is fine according to our bc promise: http://php-http.readthedocs.io/en/latest/httplug/backwards-compatibility.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm already using my fork on production but will switch back to this package asap and ping here when done 😉 |
Just tested it and it works 👍 |
thanks. i tagged 1.4.0 with this. |
Add support for
nyholm/psr7
's factories.