Add composer plugin to auto-install missing implementations #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jan 18, 2023
|
PR is ready. It comes with updates to the CI. (The remaining failures are unrelated) |
This was referenced Jan 20, 2023
Merged
dbu
reviewed
Feb 8, 2023
There was a problem hiding this comment.
thanks a lot for the contribution!
and thanks for the cleanup of the build system. i will extract those changes into a separate MR to fix the issues separately.
i have a few questions, mostly requesting more documentation to make the configuration of the plugin understandable without understanding the algorithm in its very details.
|
i merged the build setup cleanups to 1.x branch. please rebase this MR :-) |
|
PR rebased and green, comments addressed. Thanks for the review! |
dbu
reviewed
Feb 8, 2023
dbu
reviewed
Feb 8, 2023
dbu
reviewed
Feb 8, 2023
dbu
reviewed
Feb 8, 2023
dbu
reviewed
Feb 8, 2023
|
Comments addressed |
|
Rebased, all green, ready for merge + tag :) |
This was referenced Feb 9, 2023
Closed
|
just to ping the relevant people: this PR lead to a breaking change for the current minor version which was reported in #213 no offence. |
|
It also has a bug, running composer install now with the plugin enabled leads to an infinite loop of composer install |
Tofandel
reviewed
Feb 9, 2023
Tofandel
reviewed
Feb 9, 2023
|
There is another issue with this plugin. If you pass options to |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2023
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 10, 2023
…mplementations" (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [HttpClient] Revert support for "friendsofphp/well-known-implementations" | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This reverts PR #47950 The major features of "friendsofphp/well-known-implementations" are now available in "php-http/discovery" [v1.15.0](https://github.com/php-http/discovery/releases/tag/1.15.0), see: - php-http/discovery#209 - php-http/discovery#208 Given the extremely low download stats of "friendsofphp/well-known-implementations", I propose to just remove support for it as a bugfix: https://packagist.org/packages/friendsofphp/well-known-implementations This will save us from maintaining this integration, which is unused code in practice anyway. Commits ------- 081aa00 Revert "[HttpClient] Add support for "friendsofphp/well-known-implementations""
This was referenced Feb 14, 2023
Closed
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068 disallow php-http/discovery
leofeyer
pushed a commit
to contao/newsletter-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/comments-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/installation-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/listing-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/test-case
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/faq-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/news-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/calendar-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
leofeyer
pushed a commit
to contao/manager-bundle
that referenced
this pull request
Feb 15, 2023
Description ----------- See also php-http/discovery#208, contao/managed-edition#62 and contao/conflicts#44. Fixes the CI chain. Commits ------- 5b2b068a disallow php-http/discovery
BacLuc
added a commit
to ecamp/ecamp3
that referenced
this pull request
Apr 4, 2023
Was added in php-http/discovery in v1.15.0 PR: php-http/discovery#208 I would not activate this plugin in a lock file maintenance PR. Issue to maybe enable the plugin: #3401
BacLuc
added a commit
to ecamp/ecamp3
that referenced
this pull request
Apr 5, 2023
Was added in php-http/discovery in v1.15.0 PR: php-http/discovery#208 I would not activate this plugin in a lock file maintenance PR. Issue to maybe enable the plugin: #3401
brandon-reed1
added a commit
to brandon-reed1/Discovery
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes discovery able to auto-install a missing implementation when a dependency requires both php-http/discovery and one of the supported
*-implementationvirtual packages.The code comes from https://github.com/FriendsOfPHP/well-known-implementations, which I plan to retire if this approach is accepted.
Note that we started discussing this topic with @dbu at SymfonyCon and we agreed this could be the best path forward.
To Do
http-interop/http-factory-guzzlewhen Guzzle's PSR-7 v1 is needed/installed and PSR-17 implementation is required