-
Notifications
You must be signed in to change notification settings - Fork 46
Add httpsoft/http-message
(PSR-17 factories) support
#241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't know about httpsoft, thanks for the pull request.
is this implementation linked to yii or not really? if it has some default ties, you could define a "stickyness" rule to pick httpsoft when yii is present.
if you add it there, also add a test case to the installation check
the roave BC check step is broken, we unfortunately need to ignore it for now. can you please rebase on the 1.x branch? |
# Conflicts: # CHANGELOG.md
No. httpsoft is independent organization.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@nicolas-grekas any concerns or ok to merge?
btw, i noticed that you use the psr-7 integration tests. if you want you could add httpsoft to the that repository to increase visibility of httpsoft.
|
What's in this PR?
Add
httpsoft/http-message
(PSR-17 factories) supportChecklist