feat: remove ergebnis/composer-normalize #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems to work. but we have some dev dependencies in composer.json require-dev so that people can run them locally, same with phpspec. is there an issue with having normalize in the require-dev section? |
|
Only deprecations in the testruns for PHP 8.4. I have created a PR. But i thought maybe it is not needed anymore, as it runs via docker gh actions. |
|
@Chris53897 the fix to localheinz/diff has been merged and tagged. did that solve the deprecations, can we close this MR? |
|
Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to test CI if is needed "ergebnis/composer-normalize" while it runs via docker gh actions