Skip to content

Fix curl command of CurlFormatter when there is an user-agent header #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2017
Merged

Fix curl command of CurlFormatter when there is an user-agent header #82

merged 1 commit into from
Jun 28, 2017

Conversation

aaa2000
Copy link
Contributor

@aaa2000 aaa2000 commented Jun 28, 2017 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

The curl formatter display an invalid curl command when the request has an user-agent header

Why?

Instead of this curl command

curl 'http://example.com' --head-A 'Mozilla/5.0'

the formatter should format like this:

curl 'http://example.com' --head -A 'Mozilla/5.0'

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

Nyholm
Nyholm approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR with docs and tests. Thanks!

@Nyholm Nyholm merged commit e033e4f into php-http:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaa2000 @Nyholm