Add support for PHPUnit 8 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I've tagged 1.0, We can branch out later if we want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fix a Slim-Psr7 compatibility issue with PHP 7.4, I ran into a bunch of failing tests due to PHPUnit 7.x not being fully compatible with PHP 7.4. These issues were fixed in PHPUnit 8, but Slim-Psr7 can't be tested with PHPUnit 8 unless this library (which Slim-Psr7 depends on) also supports PHPUnit 8.
Unfortunately it doesn't appear possible to support both PHPUnit 8 and PHPUnit 7/6/5 at the same time when implementing methods like
setUpthat have a void return type. So it may be best to either merge this PR into a branch other than master, or else tag a release, so libraries that don't support PHPUnit 8 can use it as their dependency version instead of dev-master.