allow the whole range of react stream pre-releases #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samuelnogueira i wanted to release a new version after merging #28 and checked the diff again, and noticed that version constraint on react/stream. does it make sense as i specify it here? |
|
Actually, is it possible to remove the constraint on react/stream altogether, given that it isn't directly used by this library? |
|
actually.... lets see if travis-ci agrees that we can drop this. |
|
@shulard travis-ci thinks this is ok. do you agree? |
|
Hello, I think it's ok the react/stream dependency was used before relying on StreamFactory. If this part is required by react elsewhere it will be defined as a dependency on the corresponding lib. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allow all versions of react/stream between 0.4.3 and 0.8 instead of only 0.4 and 0.8 versions.
Why?
Semver for 0.x releases only includes a minor version when using
^.