drop old php versions #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged, could we get another tag? |
|
unless there are other open questions or things you noticed, i think we can release a new version, yes. did you try if things actually work with dns 1.0 in your setup? that would be good to know before we release. |
|
I'm updating the project right now. Once we know for certain that it worked, I'll ping back on this PR. |
xabbuh
approved these changes
Jul 30, 2019
|
We just finished testing, no issues reported! |
|
awesome, thanks for the notification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove old PHP versions.
Why?
HHVM is dead, and PHP < 7.1 are not maintained at all anymore.