Skip to content

Fix config.w32 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix config.w32 #38

merged 1 commit into from
Apr 12, 2021

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Apr 12, 2021

It is important to use consistent names for the Windows build system.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
cmb69 Christoph M. Becker
It is important to use consistent names for the Windows build system.
@cmb69
Copy link
Contributor Author

cmb69 commented Apr 12, 2021

With these changes, the build succeeds up to the link stage, but then fails. I'll provide a PR for AppVeyor CI shortly, what may be helpful to figure out what's wrong.

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

@cmb69 thank you very much. I am sry about this, with all the refactor i forgot to give config.w32 some love and update it as well 😞

@nick-zh nick-zh merged commit 7757f7f into php-kafka:main Apr 12, 2021
@cmb69 cmb69 deleted the cmb/fix-win-build branch April 12, 2021 10:39
@cmb69
Copy link
Contributor Author

cmb69 commented Apr 12, 2021

No problem. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants