-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppVeyor CI integration #39
Conversation
clone_folder: C:\projects\php_simple_kafka_client | ||
environment: | ||
BIN_SDK_VER: 2.2.0 | ||
DEP: librdkafka-1.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEP: librdkafka-1.5.3 | |
DEP: librdkafka-1.6.1 |
Iif it is available, it would be great to use the latest version
I setup the project on AppVeyor, i hope the next change triggers the build, manually i was somehow only able to build the main branch 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, 1.5.3 is the newest version available for now. Since these libs have to be built manually, I'm hoping to switch to vcpkg, but they have only 1.5.0, so I suggest to stick with 1.5.3 for a while.
manually i was somehow only able to build the main branch
Yes, that's a bit contrieved. You might need to change the default branch
under Settings
to be able to manually trigger a build. However, there is a build in my fork which succeeded (basically this PR + PR #40). Anyhow, I'm going to push a rebased version of this patch right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppVeyor CI is running. \o/
We set up basic AppVeyor CI integration for building and packaging on Windows.
Yay the build passed 🎉 |
Well, that depends. There is currently an issue with the different librdkafka versions required for this package and rdkafka. These have to be swapped manually on the PECL build machine due to limitations of the build system. So if librdkafka-1.2.1 would be installed, building of this package would fail. I'll keep an eye on that, and can retrigger a build if necessary. |
oh i see, i was under the assumption, that this is per extension not on a global level 😄 If so, i would go ahead and merge this branch and create a new release later 🎉 |
Also any way i can help out in fixing this in the build system somewhere? |
I think that should be fixed with PR #40.
No, it's rather primitive. There are directories for the different VS versions and architectures. where all dependency libraries have subdirectories, and whenever an extension is built, it just uses what is available there. We could work around by having different names for the libraries, but that might be more confusing than helpful. I think the PECL build system for Windows needs to be replaced by something else (maybe similar to the AppVeyor builds) in the long run, anyway. |
Thanks a lot for the insight 🙇 and thx again for helping out with the windows build 🎉 |
Worked like a charm, DLLs were generated successfully, thx again 🎉 |
We set up basic AppVeyor CI integration for building and packaging on
Windows.