Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor CI integration #39

Merged
merged 1 commit into from
Apr 12, 2021
Merged

AppVeyor CI integration #39

merged 1 commit into from
Apr 12, 2021

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Apr 12, 2021

We set up basic AppVeyor CI integration for building and packaging on
Windows.

clone_folder: C:\projects\php_simple_kafka_client
environment:
BIN_SDK_VER: 2.2.0
DEP: librdkafka-1.5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEP: librdkafka-1.5.3
DEP: librdkafka-1.6.1

Iif it is available, it would be great to use the latest version
I setup the project on AppVeyor, i hope the next change triggers the build, manually i was somehow only able to build the main branch 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, 1.5.3 is the newest version available for now. Since these libs have to be built manually, I'm hoping to switch to vcpkg, but they have only 1.5.0, so I suggest to stick with 1.5.3 for a while.

manually i was somehow only able to build the main branch

Yes, that's a bit contrieved. You might need to change the default branch under Settings to be able to manually trigger a build. However, there is a build in my fork which succeeded (basically this PR + PR #40). Anyhow, I'm going to push a rebased version of this patch right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor CI is running. \o/

We set up basic AppVeyor CI integration for building and packaging on
Windows.
@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

Yay the build passed 🎉
Does that mean the DLL should now also be properly created for the next release? 😄

@cmb69
Copy link
Contributor Author

cmb69 commented Apr 12, 2021

Does that mean the DLL should now also be properly created for the next release?

Well, that depends. There is currently an issue with the different librdkafka versions required for this package and rdkafka. These have to be swapped manually on the PECL build machine due to limitations of the build system. So if librdkafka-1.2.1 would be installed, building of this package would fail. I'll keep an eye on that, and can retrigger a build if necessary.

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

oh i see, i was under the assumption, that this is per extension not on a global level 😄
But except that, the build should work? Just because the latest logs you provided seemed to indicate an error

If so, i would go ahead and merge this branch and create a new release later 🎉

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

Also any way i can help out in fixing this in the build system somewhere?
If so, please let me know, i would be glad to help out if i can

@cmb69
Copy link
Contributor Author

cmb69 commented Apr 12, 2021

Just because the latest logs you provided seemed to indicate an error

I think that should be fixed with PR #40.

oh i see, i was under the assumption, that this is per extension not on a global level

No, it's rather primitive. There are directories for the different VS versions and architectures. where all dependency libraries have subdirectories, and whenever an extension is built, it just uses what is available there. We could work around by having different names for the libraries, but that might be more confusing than helpful. I think the PECL build system for Windows needs to be replaced by something else (maybe similar to the AppVeyor builds) in the long run, anyway.

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

Thanks a lot for the insight 🙇 and thx again for helping out with the windows build 🎉
I'll do another release later tonight 👍

@nick-zh nick-zh merged commit c2c0c9a into php-kafka:main Apr 12, 2021
@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

Worked like a charm, DLLs were generated successfully, thx again 🎉

@cmb69 cmb69 deleted the cmb/appveyor branch November 26, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants