Skip to content

Add support for 64-bit numbers in increment/decrement operations #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

reva2
Copy link

@reva2 reva2 commented Oct 24, 2014

Add support for 64-bit numbers in increment/decrement operations.

Fixes #58

@mkoppanen
Copy link
Member

Hmm, zend_parse_parameters "l" expects "long" as the type so I am not sure how this behaves on 32bit

@reva2
Copy link
Author

reva2 commented Oct 27, 2014

Hello Mikko.

I fixed issue with signed values as a param for increment/decrement functions. Now tests related to increment/decrement operations passing successfully.

I'm not expert in C/C++ so I'm also not sure how it will behaves on 32bit. But because for param 'initial' you use the same type and zend_parse_parameters mask I think it should work also with param 'offset'. If you have better suggestions I will be glad to hear it.

Related to failed travis build. I've checked build results and found that it the same as results for master branch. It fails only on new test which was added in one of latest commits. I thinks this issue is not related to my changes.

@sodabrew sodabrew modified the milestones: 3.1.0, 2.3.0 Jan 24, 2017
@sodabrew sodabrew modified the milestones: 3.0.0, 3.1.0 Jan 25, 2017
@sodabrew
Copy link
Contributor

Thanks for the original contribution here! I've prepared a new PR to do this more concisely. Closing and will be resolved in php-memcached 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increment can't bigger than 4294967295
4 participants