Move working tests out of the experimental folder #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to fix up some of the tests, but some of them are broken beyond my comprehension. Some tests have differences based on PHP version. Perhaps working tests should be moved out of the experimental folder? |
|
I've moved working tests out of the experimental folder, so there's more passing tests on the CI now. There's less than 10 tests left in experimental folder, unfortunately I'm not entirely sure how to fix them (and some of them start failing on newer php versions). |
xPaw
changed the title
|
@remicollet is there any interest in merging this? |
|
Thanks for doing this! Helpful to isolate the few non-working tests for future improvement. |
hydrapolic
added a commit
to hydrapolic/gentoo-1
that referenced
this pull request
Oct 8, 2023
Tests are failing in the previous snapshot. php-memcached-dev/php-memcached#503 Bug: https://bugs.gentoo.org/909753 Signed-off-by: Tomáš Mózes <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 23, 2023
Tests are failing in the previous snapshot. php-memcached-dev/php-memcached#503 Bug: https://bugs.gentoo.org/909753 Closes: #33244 Signed-off-by: Tomáš Mózes <[email protected]> Signed-off-by: Michael Orlitzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should do the trick.