GH Actions: update PHP version for PHAR boxing #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like Box silently dropped support for PHP 8.1. Upgrading the version on which Box is run to 8.2 should fix this. The resulting PHAR files should still work fine on PHP < 8.2. Ref: https://github.com/box-project/box/releases Note: this commit will need to be back-ported to the `master` branch to get passing builds there again too.
|
I'm going to merge this PR as otherwise we'll not be able to test other changes via CI. |
|
Darn! I can't due to the branch protection settings and I can't update those. @grogy Can you please approve & merge this ASAP ? |
grogy
approved these changes
Mar 27, 2024
That's why I mentioned that they "silently" did this (i.e. no mention in the changelog). For reference: here is the PR in which Box dropped PHP < 8.1 support. P.S.: have a look at your DMs on Twitter. |
|
Ahh... thank you for the link To master I put commit: https://github.com/php-parallel-lint/PHP-Parallel-Lint/commits/master Twitter - ok ok :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Box silently dropped support for PHP 8.1. Upgrading the version on which Box is run to 8.2 should fix this. The resulting PHAR files should still work fine on PHP < 8.2.
Ref: https://github.com/box-project/box/releases
Note: this commit will need to be back-ported to the
masterbranch to get passing builds there again too.