Skip to content

jsonSerialize ignore optional attributes #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eav93 opened this issue Mar 29, 2022 · 2 comments
Closed

jsonSerialize ignore optional attributes #1303

eav93 opened this issue Mar 29, 2022 · 2 comments
Assignees
Labels
bug next release Issue gets resolved with the next release.

Comments

@eav93
Copy link

eav93 commented Mar 29, 2022

🐞 Bug Report

$data = [
            'reply_markup' => (new Keyboard(
                [
                    'One',
                    'Two'
                ],
                [
                    'Three',
                    'Four',
                ]
            ))->setResizeKeyboard(true)
        ];

Entity::jsonSerialize() return only raw_data but does not return optional attributes: resize_keyboard, one_time_keyboard, etc...

@eav93 eav93 added the bug label Mar 29, 2022
@TiiFuchs TiiFuchs self-assigned this Mar 30, 2022
@TiiFuchs
Copy link
Member

Can confirm. I'm working on a fix.

TiiFuchs added a commit that referenced this issue Mar 30, 2022
@TiiFuchs
Copy link
Member

This bug has nothing to do with the introduction of jsonSerialize. It was there before.
I fixed it with PR #1304 though. Should be in the next release. Trying to release later today.

@TiiFuchs TiiFuchs added the next release Issue gets resolved with the next release. label Mar 30, 2022
noplanman added a commit that referenced this issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug next release Issue gets resolved with the next release.
Projects
None yet
Development

No branches or pull requests

2 participants