Remove bot token from debug stream #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove bot token from debug http log streams, specifically from the URL path, I don't think there is any other place the token shows up?
So this:
becomes this:
Can be disabled on demand with
TelegramLog::$remove_bot_token = false
.Having it enabled as default will make it safe for the people to post these logs for troubleshooting.
Regex is literally modified one from
Telegram.php:172
.My original idea was to cache the token in the class to not run regex for each entry but people might be running some weird setups where they handle multiple bots in single script.