Document get_error_handler(), get_exception_handler() #4567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
commented
Mar 27, 2025
| <refentry xml:id="function.get-error-handler" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <refnamediv> | ||
| <refname>get_error_handler</refname> | ||
| <refpurpose>Gets the user-defined error handler function</refpurpose> |
There was a problem hiding this comment.
Using the same terminology as in
|
LGTM! One potential improvement is to add an alternative for the pre-8.5 world as an example. |
|
@philip I've added a note, inspired from the one in https://www.php.net/array_key_first |
Fan2Shrek
reviewed
Apr 17, 2025
| &reftitle.examples; | ||
| <para> | ||
| <example> | ||
| <title><function>get_error_handler</function></title> |
There was a problem hiding this comment.
Suggested change
| <title><function>get_error_handler</function></title> | |
| <title><function>get_error_handler</function> example</title> |
Same bellow :)
Girgias
reviewed
Apr 21, 2025
Comment on lines
+37
to
+39
| &reftitle.examples; | ||
| <para> | ||
| <example> |
There was a problem hiding this comment.
Minor nit, there is no need for the wrapping <para> tags around the example
Comment on lines
+90
to
+92
| &reftitle.seealso; | ||
| <para> | ||
| <simplelist> |
There was a problem hiding this comment.
Ditto no need for the wrapping para tag here
Comment on lines
+37
to
+39
| &reftitle.examples; | ||
| <para> | ||
| <example> |
Comment on lines
+63
to
+68
| &reftitle.notes; | ||
| <tip> | ||
| <simpara> | ||
| Prior to PHP 8.5.0, this functionality can be provided by the following | ||
| polyfill: | ||
| </simpara> |
Comment on lines
+90
to
+93
| &reftitle.seealso; | ||
| <para> | ||
| <simplelist> | ||
| <member><function>set_exception_handler</function></member> |
Girgias
pushed a commit
that referenced
this pull request
May 20, 2025
Followup of #4567 to address post-merge comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/get-error-exception-handler