Generate ext/pdo methodsynopses based on stubs #494
Conversation
kocsismate
force-pushed
the
pdo-stubs
branch
2 times, most recently
from
1dc3cfa to
b061511
Compare
There was a problem hiding this comment.
This looks ok to me now. I still have a feeling we missed something. @cmb69 What's your opinion?
|
From a quick look, this looks okay. Of course, there is the issue that some of these methods may not return false on failure for ERRMODE_EXCEPTION, but I don't think it's worth to explicitly document that (IMHO, letting clients choose how issues are reported is a bad idea in the first place). |
|
@cmb69 Yeah, I noticed that too, but I think we can make a separate PR for that. The return values will have to be adjusted for the new signatures. |
| <varlistentry xml:id="pdo.constants.fetch-default"> | ||
| <term> | ||
| <constant>PDO::FETCH_DEFAULT</constant> | ||
| (<type>int</type>) | ||
| </term> | ||
| <listitem> | ||
| <simpara> | ||
| Specifies that the default fetch mode shall be used. | ||
| </simpara> | ||
| </listitem> | ||
| </varlistentry> |
There was a problem hiding this comment.
Hello, just stumbled over this constant. As nice as it would be, it does not exist (8.0.6). Or is this planned?
Fatal error: Uncaught Error: Undefined constant PDO::FETCH_DEFAULT
There was a problem hiding this comment.
We documented it a bit prematurely... since the constant has just been added by php/php-src#6937, it's going to be available in the next patch release
There was a problem hiding this comment.
Please add that info ("Available as of PHP 8.0.7.")
There was a problem hiding this comment.
Submitted: #597 Although I'm wondering if this information should be added to the usages of the constant?
No description provided.