Skip to content

sqlite3_defensive.phpt fails with sqlite 3.44.0 #12633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andypost opened this issue Nov 8, 2023 · 2 comments
Closed

sqlite3_defensive.phpt fails with sqlite 3.44.0 #12633

andypost opened this issue Nov 8, 2023 · 2 comments

Comments

@andypost
Copy link
Contributor

andypost commented Nov 8, 2023

Description

The ext/sqlite3/tests/sqlite3_defensive.phpt test started to fail after upgrade of SQLite to 3.44.0 on all arches

Resulted in this output:

TEST 12220/16282 [ext/sqlite3/tests/sqlite3_defensive.phpt]
========DIFF========
     bool(true)
003+ int(0)
     int(1)
004- int(1)
     
     Warning: SQLite3::querySingle(): Unable to prepare statement: 1, table sqlite_master may not be modified in %s on line %d
     bool(false)

PHP Version

PHP 8.1.25 and later

Operating System

Alpinelinux

@SakiTakamachi
Copy link
Member

I'll see this later.

@SakiTakamachi
Copy link
Member

Probably due to this change. It looks like the test needs to be modified.

The SQLITE_DBCONFIG_DEFENSIVE setting now prevents PRAGMA writable_schema from being turned on. Previously writable_schema could be turned on, but would not actually allow the schema to be writable. Now it simply cannot be turned on.

https://www.sqlite.org/releaselog/3_44_0.html

nielsdos added a commit that referenced this issue Nov 9, 2023
* PHP-8.1:
  Fix GH-12633: sqlite3_defensive.phpt fails with sqlite 3.44.0
  Fix GH-12628: The gh11374 test fails on Alpinelinux
nielsdos added a commit that referenced this issue Nov 9, 2023
* PHP-8.2:
  Fix GH-12633: sqlite3_defensive.phpt fails with sqlite 3.44.0
  Fix GH-12628: The gh11374 test fails on Alpinelinux
nielsdos added a commit that referenced this issue Nov 9, 2023
* PHP-8.3:
  Fix GH-12633: sqlite3_defensive.phpt fails with sqlite 3.44.0
  Fix GH-12628: The gh11374 test fails on Alpinelinux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants