Skip to content

xsl cannot build on PHP 8.4 #13764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvorisek opened this issue Mar 20, 2024 · 1 comment · Fixed by #13770
Closed

xsl cannot build on PHP 8.4 #13764

mvorisek opened this issue Mar 20, 2024 · 1 comment · Fixed by #13770

Comments

@mvorisek
Copy link
Contributor

Description

...
#11 212.5  cc -I. -I/usr/src/php/ext/xsl -I/usr/src/php/ext/xsl/main -I/usr/src/php/ext/xsl -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -I/usr/include/libxml2 -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DZEND_COMPILE_DL_EXT=1 -c /usr/src/php/ext/xsl/php_xsl.c -MMD -MF php_xsl.dep -MT php_xsl.lo  -fPIC -DPIC -o .libs/php_xsl.o
#11 212.5  cc -I. -I/usr/src/php/ext/xsl -I/usr/src/php/ext/xsl/main -I/usr/src/php/ext/xsl -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -I/usr/include/libxml2 -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_CONFIG_H -fstack-protector-strong -fpic -fpie -O2 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DZEND_COMPILE_DL_EXT=1 -c /usr/src/php/ext/xsl/xsltprocessor.c -MMD -MF xsltprocessor.dep -MT xsltprocessor.lo  -fPIC -DPIC -o .libs/xsltprocessor.o
#11 212.7 /usr/src/php/ext/xsl/xsltprocessor.c:26:10: fatal error: ext/dom/php_dom.h: No such file or directory
#11 212.7    26 | #include "ext/dom/php_dom.h"
#11 212.7       |          ^~~~~~~~~~~~~~~~~~~
#11 212.7 compilation terminated.
#11 212.7 make: *** [Makefile:212: xsltprocessor.lo] Error 1

full CI log: https://github.com/mvorisek/image-php/actions/runs/8340233004/job/22823773226#step:9:8463

The issue is simillar to #13745, the issue is present when the module is build separately, ie. there is some linking issue.

PHP Version

master

Operating System

any (tested Debian and Alpine)

nielsdos added a commit to nielsdos/php-src that referenced this issue Mar 20, 2024
Move some of the DOM APIs from the non-public php_dom.h header to the
public header xml_common.h.
@nielsdos nielsdos linked a pull request Mar 20, 2024 that will close this issue
@nielsdos
Copy link
Member

@mvorisek Please test #13770, thanks.

nielsdos added a commit that referenced this issue Mar 20, 2024
Move some of the DOM APIs from the non-public php_dom.h header to the
public header xml_common.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants