DOMNodeList::item may return DOMElement. #11342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not explicitly documenting the possibility of returning DOMElement causes the Intelephense linter (a popular PHP linter with ~9 million downloads: https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client ) to think this code is bad: $xp->query("whatever")->item(0)->getAttribute("foo"); because DOMNode does not have getAttribute (while DOMElement does). documenting the DOMElement return type should fix Intelephense's linter.
nielsdos
approved these changes
May 29, 2023
There was a problem hiding this comment.
Note that when changing stub files you should also update the arginfo C file by running build/gen_stub.php, and add that file (in this case only the hash changes though so it isn't a big deal). You don't have to change it now in this case, I can do it during the merge as I'll have to do it anyway when merging upwards.
Patch looks good to me. I'll wait until CI finishes. Thanks for you contribution.
|
CI complains about the generated arginfo files, like I already hinted at. Other than that looks good, I'll merge this. |
kocsismate
added a commit
to php/doc-en
that referenced
this pull request
Oct 28, 2023
DOMElement was missing until php/php-src#11342 fixed the return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not explicitly documenting the possibility of returning DOMElement causes the Intelephense linter (a popular PHP linter with ~9 million downloads: https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client ) to think this code is bad:
$xp->query("whatever")->item(0)->getAttribute("foo");
because DOMNode does not have getAttribute (while DOMElement does). documenting the DOMElement return type should fix Intelephense's linter.