Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES #12970

Closed
wants to merge 2 commits into from
Closed

Fix GH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES #12970

wants to merge 2 commits into from

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Dec 18, 2023 •
edited
Loading

Partial backport of #12793
(I done cherry-pick and kept only the changes I needed)

@SakiTakamachi SakiTakamachi changed the base branch from master to PHP-8.2 December 18, 2023 14:28
@SakiTakamachi SakiTakamachi changed the title Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES Fix GH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES Dec 18, 2023
@SakiTakamachi SakiTakamachi marked this pull request as ready for review December 18, 2023 14:44
@SakiTakamachi SakiTakamachi marked this pull request as draft December 18, 2023 15:17
@SakiTakamachi SakiTakamachi marked this pull request as ready for review December 18, 2023 15:45
@SakiTakamachi SakiTakamachi mentioned this pull request Dec 18, 2023
Closed
Girgias
Girgias approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias self-assigned this Dec 22, 2023
@nielsdos nielsdos closed this in b333164 Dec 22, 2023
@SakiTakamachi
Copy link
Member Author

Thank you!

@SakiTakamachi SakiTakamachi deleted the fix/gh-12969 branch March 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

@Girgias Girgias

Labels
Extension: pdo (core) Extension: pdo_mysql Extension: pdo_pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SakiTakamachi @Girgias