ext/standard: Add get_declared_enums function
#15443
Conversation
Ayesh
requested review from
kocsismate,
dstogov,
iluuu1994 and
bukka
as code owners
github-actions
bot
added
Category: Engine
Extension: standard
Category: Optimizer
labels
Ayesh
changed the title
get_declared_enums\ functionget_declared_enums function
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
cea03f6 to
f702eaf
Compare
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
f702eaf to
45b80b8
Compare
Ayesh
force-pushed
the
get_declared_enums-2
branch
2 times, most recently
from
9c8f154 to
18d4150
Compare
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
18d4150 to
7c38bc2
Compare
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
7c38bc2 to
7192914
Compare
There was a problem hiding this comment.
I don't see any problems.
Not sure if somebody need this, but implementation is really small.
@iluuu1994 please make a final decision.
|
Thank you so much @dstogov for the review. If the RMs / @iluuu1994 would like to have this on PHP 8.4, that'll be super awesome! |
|
@dstogov FYI: Based on a preliminary discussion about this on the internals mailing list, this will need an RFC. I've prepared one in draft and we (@Ayesh and me) intend to open the formal discussion period for the RFC some time this week (probably once the discussion around default expressions has died down a little). |
|
@Ayesh snap! What a timing ;-) |
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
7192914 to
2b9ffa9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Adds a `get_declared_enums()` function that returns a list of declared Enums. This function is similar to the existing `get_declared_(classes|interfaces|traits)` functions. Co-Authored-By: Ilija Tovilo <[email protected]>
Ayesh
force-pushed
the
get_declared_enums-2
branch
from
2b9ffa9 to
2aa0770
Compare
Adds a
get_declared_enums()function that returns a list of declared Enums. This function is similar to the existingget_declared_(classes|interfaces|traits)functions.RFC: https://wiki.php.net/rfc/get_declared_enums