Skip to content

Exclude vm files from the ABI break label #16083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 requested a review from cmb69 September 27, 2024 10:31
@iluuu1994 iluuu1994 requested a review from TimWolla as a code owner September 27, 2024 10:31
@cmb69
Copy link
Member

cmb69 commented Sep 27, 2024

Why do we install these files in the first place?

@iluuu1994
Copy link
Member Author

iluuu1994 commented Sep 27, 2024

@cmb69 No idea. zend_vm_def.h is DSL and so entirely useless for the client. zend_vm_execute.h is not a true header file, as it's included in zend_execute.c. The few non-static functions are actually forward declared in Zend/zend_vm.h, which is the header you should use if you were to call any of them.

@petk
Copy link
Member

petk commented Sep 27, 2024

Why do we install these files in the first place?

I think mostly due to laziness. In the beginning it was probably easier to write wildcard expression to find all the *.h files inside the Zend and main directory, than to write them separately on multiple places.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was actually a rhetoric question. :) I suggest to unpublish these files via #16070.

Not sure about this PR. We may leave the labeler do its thing, as a reminder of what we did (namely to publish files which have not supposed to be published).

@iluuu1994
Copy link
Member Author

Ok, I'll let you handle this then. It would be nice to fix this for older branches though, for the headers that have already been fixed on master.

@iluuu1994 iluuu1994 closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants