Simplify parsing of affine matrix arguments #17094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code repetition is prone to errors and makes the code harder to read than necessary. We simplify at the cost of making parsing of ints slightly less performant (what should not really matter in practice).
So far this is fully backwards compatible. However, given that the
$clip
argument ofimageaffine()
useszend_get_long()
without further type checks, we could usezend_get_double()
for the matrix arguments also without further type checks. Or perhaps being more strict. As is, the documentation (which is highly incomplete for now) would need to go to great lengths to explain which types are supported for the array elements and how they are handled.