Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Request the output of php -v in the bug_report.yml issue template #18230

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Apr 2, 2025

The output of php -v immediately shows whether OPcache is loaded and whether PHP is a NTS/ZTS and Debug/Release build.

…e template

The output of `php -v` immediately shows whether OPcache is loaded and whether
PHP is a NTS/ZTS and Debug/Release build.
@TimWolla TimWolla force-pushed the bug-report-template-version branch from 0399403 to 6c79459 Compare April 2, 2025 15:25
@TimWolla TimWolla changed the title Request the output of php -v in the bug_report.yml issue template [skip ci] Request the output of php -v in the bug_report.yml issue template Apr 2, 2025
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't check whether this works before merging it, right?
In any case, I'm in favor.

@TimWolla
Copy link
Member Author

TimWolla commented Apr 2, 2025

We can't check whether this works before merging it, right?

We can. GitHub renders a preview at: https://github.com/TimWolla/php-src/blob/bug-report-template-version/.github/ISSUE_TEMPLATE/bug_report.yml

I've also stolen it from the template that I've written for HAProxy: https://github.com/haproxy/haproxy/blob/dd900aead8613af12ea23b18a3e77d28ad42729b/.github/ISSUE_TEMPLATE/Bug.yml#L77-L87

@nielsdos
Copy link
Member

nielsdos commented Apr 2, 2025

Seems good! Thanks

@TimWolla
Copy link
Member Author

TimWolla commented Apr 3, 2025

I'll leave this open for a few more days for folks to come across it and raise objections and otherwise merge.

@TimWolla TimWolla merged commit ea6f2fb into php:master Apr 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants