Add OffsetTime* Exif tags #18237
Closed
Add OffsetTime* Exif tags #18237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should have kept this a draft before the CI was done, apologies for that. Anyway, the pull request is now ready for review. You can review correctness of the hex codes for the Tag IDs, e. g., via the Exif 3.0 specification available from https://www.cipa.jp/std/documents/download_e.html?CIPA_DC-008-2024-E. |
nielsdos
approved these changes
Apr 4, 2025
|
Merged (squashed) into master (i.e. PHP-8.5 dev branch) with a NEWS and UPGRADING entry. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the OffsetTime, OffsetTimeOriginal, and OffsetTimeDigitized Exif tags as I need them to take different time zones into account when sorting images.
I have added a test, but need to add that I am currently not set up to compile PHP locally, so I am counting on your CI for that or a reviewers assistance.
Thanks in advance for considering my request!