Skip to content

cli: Fix swapped output in php --ini #18557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

schneems
Copy link
Contributor

In #18527, I accidentally swapped the values. This is before my modification:

zend_printf("Configuration File (php.ini) Path: %s\n", PHP_CONFIG_FILE_PATH);
zend_printf("Loaded Configuration File:         %s\n", php_ini_opened_path ? php_ini_opened_path : "(none)");
zend_printf("Scan for additional .ini files in: %s\n", php_ini_scanned_path  ? php_ini_scanned_path : "(none)");
  • "Loaded Configuration File" should be php_ini_opened_path
  • "Scan for additional .ini files in" shoudl be php_ini_scanned_path

In php#18527, I accidentally swapped the values. This is before my modification:

```
zend_printf("Configuration File (php.ini) Path: %s\n", PHP_CONFIG_FILE_PATH);
zend_printf("Loaded Configuration File:         %s\n", php_ini_opened_path ? php_ini_opened_path : "(none)");
zend_printf("Scan for additional .ini files in: %s\n", php_ini_scanned_path  ? php_ini_scanned_path : "(none)");
```

- "Loaded Configuration File" should be `php_ini_opened_path`
- "Scan for additional .ini files in" shoudl be `php_ini_scanned_path`
@devnexen devnexen requested a review from Girgias May 14, 2025 18:33
@TimWolla TimWolla changed the title Fix swapped variables cli: Fix swapped output in php --ini May 14, 2025
@TimWolla TimWolla merged commit 89dc8d7 into php:master May 14, 2025
9 checks passed
@schneems
Copy link
Contributor Author

Thanks, and sorry about that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants