Skip to content

maybe fix #8517, split PR from #8785 #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

maybe fix #8517, split PR from #8785 #8794

wants to merge 1 commit into from

Conversation

hwde
Copy link
Contributor

@hwde hwde commented Jun 15, 2022

No description provided.

@hwde hwde mentioned this pull request Jun 15, 2022
Closed
@Girgias Girgias requested a review from bukka June 16, 2022 02:21
devnexen
devnexen approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fix makes sense but a confirmation from @bukka would be good.

@bukka
Copy link
Member

bukka commented Jun 27, 2022

The commit message should be changed though as it doesn't fix that issue looks like.

@devnexen
Copy link
Member

closed with 325ca31. Thank you.

@devnexen devnexen closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwde @bukka @devnexen @saundefined