Skip to content

Skip locale tests /w musl libc #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

Skip locale tests /w musl libc #9141

merged 1 commit into from
Jul 25, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jul 25, 2022 •
edited
Loading

locale support is broken /w musl libc (used as default in Alpine OS), thus these tests must be skipped

isolated from #8621

@nikic
Copy link
Member

nikic commented Jul 25, 2022

This is not an alpine-specific problem, but rather a musl-specific one. I think that we should either a) detect that setlocale error reporting is broken (if (setlocale(LC_ALL, "invalid locale")) die("setlocale() is broken") or b) expose that we are linking musl and check that.

@mvorisek mvorisek marked this pull request as draft July 25, 2022 19:25
@mvorisek mvorisek changed the title Skip broken locale tests on Alpine OS Skip locale tests /w musl libc Jul 25, 2022
@mvorisek mvorisek force-pushed the skip_locale_tests_alpine branch from 149d5a2 to 1ff19d3 Compare July 25, 2022 19:40
@mvorisek mvorisek marked this pull request as ready for review July 25, 2022 19:40
@mvorisek
Copy link
Contributor Author

@nikic thanks, PR updated

nikic
nikic approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@mvorisek mvorisek force-pushed the skip_locale_tests_alpine branch from 1ff19d3 to 680b6f8 Compare July 25, 2022 21:48
@Girgias Girgias merged commit 60189aa into php:master Jul 25, 2022
@mvorisek mvorisek deleted the skip_locale_tests_alpine branch July 25, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Extension: ctype Extension: fileinfo Extension: iconv Extension: pcre Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @nikic @Girgias